Skip to content

feat(c/driver_manager,rust/driver_manager): add manifest version check #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 13 commits into from
Sep 5, 2025
Merged

feat(c/driver_manager,rust/driver_manager): add manifest version check #3393

lidavidm merged 13 commits into from
Sep 5, 2025

Conversation

@zeroshade
Copy link
Member

@zeroshade zeroshade commented Sep 3, 2025

resolves #3387

@github-actions github-actions bot added this to the ADBC Libraries 20 milestone Sep 3, 2025
@zeroshade zeroshade changed the title feat(c/driver_manager,rust_driver_manager): add manifest version check feat(c/driver_manager,rust/driver_manager): add manifest version check Sep 3, 2025
ianmcook
ianmcook reviewed Sep 3, 2025
View reviewed changes
@ianmcook
Copy link
Member

ianmcook commented Sep 3, 2025 •
edited
Loading

Maybe we should use ADBC_STATUS_NOT_IMPLEMENTED instead of ADBC_STATUS_INVALID_ARGUMENT?

(In Rust it'd be Status::NotImplemented instead of Status::InvalidArguments)

@ianmcook
Copy link
Member

ianmcook commented Sep 4, 2025

I will add a commit with some docs updates.

amoeba
amoeba reviewed Sep 4, 2025
View reviewed changes
paleolimbot
paleolimbot approved these changes Sep 4, 2025
View reviewed changes
amoeba
amoeba approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks

ianmcook
ianmcook reviewed Sep 5, 2025
View reviewed changes
lidavidm
lidavidm reviewed Sep 5, 2025
View reviewed changes
@lidavidm
Copy link
Member

lidavidm commented Sep 5, 2025

Looking at the packaging failures I think that's flakiness or rate limiting between Ubuntu package mirrors and GHA.

@lidavidm lidavidm merged commit 6ce20ab into apache:main Sep 5, 2025
92 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoeba amoeba amoeba approved these changes

@ianmcook ianmcook ianmcook approved these changes

@lidavidm lidavidm lidavidm approved these changes

@paleolimbot paleolimbot paleolimbot approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 20

Development

Successfully merging this pull request may close these issues.

c/driver_manager: add manifest version to manifests and check it in driver managers

5 participants

@zeroshade @ianmcook @lidavidm @amoeba @paleolimbot