Skip to content

feat(c/driver_manager): improve error reporting for manifests #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 8 commits into from
Sep 4, 2025
Merged

feat(c/driver_manager): improve error reporting for manifests #3386

lidavidm merged 8 commits into from
Sep 4, 2025

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Sep 2, 2025

Fixes #3223.

@lidavidm lidavidm marked this pull request as ready for review September 3, 2025 01:10
@github-actions github-actions bot added this to the ADBC Libraries 20 milestone Sep 3, 2025
@ianmcook
Copy link
Member

ianmcook commented Sep 3, 2025 •
edited
Loading

For the kUnset cases, can we split up the logic to separate out the "not set" cases from the "does not exist" cases, and give them separate error messages?

@lidavidm
Copy link
Member Author

lidavidm commented Sep 3, 2025

Updated:

[Driver Manager] dlopen() failed: nosuchdriver: cannot open shared object file: No such file or directory
dlopen() failed: libnosuchdriver.so: cannot open shared object file: No such file or directory
Also searched these paths for manifests:
	not set: ADBC_DRIVER_PATH
	not enabled at build time: Conda prefix
	does not exist: /home/lidavidm/.config/adbc/drivers
	does not exist: /etc/adbc/drivers

amoeba
amoeba approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thanks.

Looks like the CI failures need attention (anonymous-namespace'::ManagedLibrary::Load': function does not take 2 arguments) before merge.

@lidavidm lidavidm merged commit e4404e7 into apache:main Sep 4, 2025
70 checks passed
@lidavidm lidavidm deleted the gh-3223 branch September 4, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amoeba amoeba amoeba approved these changes

@ianmcook ianmcook ianmcook approved these changes

@zeroshade zeroshade Awaiting requested review from zeroshade

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 20

Development

Successfully merging this pull request may close these issues.

c/driver_manager: provide more context about driver load failures

3 participants

@lidavidm @ianmcook @amoeba