feat(java/driver/jni): implement parameter binding #3370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Java API lacks a way to bind a stream, due to the general lack of a good interface for a stream in Java. So that isn't supported. Fixes apache#3369.
zeroshade
reviewed
Aug 29, 2025
| public void bind(VectorSchemaRoot root) throws AdbcException { | ||
| try (final ArrowArray batch = ArrowArray.allocateNew(allocator); | ||
| final ArrowSchema schema = ArrowSchema.allocateNew(allocator)) { | ||
| // TODO(lidavidm): we may need a way to separately provide a dictionary provider |
Member
There was a problem hiding this comment.
Does this mean we should error in the dictionary cases?
Member
Author
There was a problem hiding this comment.
It will already error since we don't provide a dictionary provider. But the APIs here need to be reconsidered a bit
zeroshade
reviewed
Aug 29, 2025
| static native void statementBind(long handle, long values, long schema) throws AdbcException; | ||
|
|
||
| // TODO(lidavidm): we need a way to bind an ArrowReader (or some other suitable interface that | ||
| // doesn't exist in arrow-java; see the discussion around the Avro reader about how ArrowReader |
Member
There was a problem hiding this comment.
can we link to the discussion you're referencing here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java API lacks a way to bind a stream, due to the general lack of a good interface for a stream in Java. So that isn't supported.
Fixes #3369.