feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name #3362
Conversation
|
The Python side is not fully wired up yet but I would appreciate opinions on using an option to tell drivers to bind parameters by name and not position. @zeroshade @amoeba @WillAyd @paleolimbot My reasoning:
The tests in this PR aren't complete yet on the Python side. |
| table, or record batch reader (to provide multiple | ||
| parameters, which will each be bound in turn). | ||
| Parameters to bind. Can be a Python sequence (to bind a single | ||
| set of parameters), a Python dictionary (to bind a single set of |
There was a problem hiding this comment.
Does providing a dictionary automatically set the option to bind by name? If not, should it?
There was a problem hiding this comment.
It will, yes. It's only when using Arrow data that you have to manage it explicitly.
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
This seems great! I'll wire it up in R after this merges (not sure there's a good way to pass through statement options to read_adbc() or execute_adbc() yet).
| "adbc.sqlite.load_extension.entrypoint"; | ||
| /// The batch size for query results (and for initial type inference) | ||
| constexpr std::string_view kStatementOptionBatchRows = "adbc.sqlite.query.batch_rows"; | ||
| constexpr std::string_view kStatementOptionBindByName = "adbc.statement.bind_by_name"; |
There was a problem hiding this comment.
Is this unique to SQLite or maybe there's another good place for "well known but also we don't really want to update adbc.h" parameters? (I recall there's a Postgres one like that too but I forget what it's called).
There was a problem hiding this comment.
We should maybe make such a header 😬 arrow-adbc/experimental.h?
|
Any other comments? |
| "adbc.sqlite.load_extension.entrypoint"; | ||
| /// The batch size for query results (and for initial type inference) | ||
| constexpr std::string_view kStatementOptionBatchRows = "adbc.sqlite.query.batch_rows"; | ||
| constexpr std::string_view kStatementOptionBindByName = "adbc.statement.bind_by_name"; |
4 participants
Closes #3262.