fix(csharp/src/Drivers/BigQuery): Include try/catch for InvalidOperationException in ReadRowsStream #3361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2025 14:33
CurtHagenlocher
approved these changes
Sep 3, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! I'm going to check this in; consider adding logging for the swallowed exception as a followup.
| } | ||
| } | ||
| else | ||
| catch (InvalidOperationException) |
Contributor
There was a problem hiding this comment.
Given that we're swallowing this exception, should we at least write something to the logs (e.g. stack trace) to ensure it's not entirely lost?
| int maxStreamCount, | ||
| Activity? activity) | ||
| { | ||
| ReadSession rs = new ReadSession { Table = table, DataFormat = DataFormat.Arrow }; |
Contributor
There was a problem hiding this comment.
I suspect that moving the session creation into the retriable part is probably what will fix this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous update was still not catching the issue. Found some older grpc classes with the similar message (
No current element is available.) and pattern including https://github.com/grpc/grpc/blob/2d4f3c56001cd1e1f85734b2f7c5ce5f2797c38a/src/csharp/Grpc.Core/Internal/ServerRequestStream.cs#L38, so added a try/catch around the attempt to add an additional check. Included some mocks to test as well.