feat(c/driver/postgresql): bind arrow.json to JSON #3333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dabla, I think the other thing you would need is for us to return Also I just noticed you mention ingest doesn't work either so that will also need to be tested. |
This also works for JSONB. This lets PostgreSQL know that the string data is actually JSON data so it can handle that properly. Closes apache#3284.
Member
Author
|
Looks like we can ingest into JSON, but we can't ingest into JSONB without another extension type (because we have to generate a slightly different representation in this case). So I'll leave that as a TODO. You can INSERT into a JSONB column, though, because Postgres knows what type you're trying to insert and can cast. (A workaround if you need to ingest into a JSONB column might be to ingest into a JSON temporary table and then do another INSERT.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also works for JSONB. This lets PostgreSQL know that the string data is actually JSON data so it can handle that properly.
Closes #3284.