Skip to content

fix(csharp/test/Drivers/Databricks): Change the default QueryTimeoutSeconds to 3 hours #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CurtHagenlocher merged 1 commit into from
Jul 18, 2025
Merged

fix(csharp/test/Drivers/Databricks): Change the default QueryTimeoutSeconds to 3 hours #3175

CurtHagenlocher merged 1 commit into from
Jul 18, 2025

Conversation

@jackyhu-db
Copy link
Contributor

@jackyhu-db jackyhu-db commented Jul 18, 2025

Motivation

Currently, the default QueryTimeoutSeconds is 60s (set by Hive2Server2Connection here), which is too short as some customers may run some large and complex queries which takes long time.

Change

Change the QueryTimeoutSeconds in the DatabricksConnection to 3 hours if it is not configured by the connection parameter in the client

Test

  • Existing E2E test
  • Test a long running query ( >. 2 mins)

@github-actions github-actions bot added this to the ADBC Libraries 20 milestone Jul 18, 2025
CurtHagenlocher
CurtHagenlocher requested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will obviously work, but I think it's pretty confusing. Can we instead put a virtual int DefaultQueryTimeoutSeconds { get; } on Hive2Connection` and then override it from DatabricksConnection?

(Feel free to push back; I don't feel super strongly about it.)

@jackyhu-db
Copy link
Contributor Author

jackyhu-db commented Jul 18, 2025 •
edited
Loading

This change will obviously work, but I think it's pretty confusing. Can we instead put a virtual int DefaultQueryTimeoutSeconds { get; } on Hive2Connection` and then override it from DatabricksConnection?

(Feel free to push back; I don't feel super strongly about it.)

I am not sure if this change will work as the initial value of QueryTimeoutSeconds is set in the base class Hive2ServerConnection, at this time it does not get the value DefaultQueryTimeoutSeconds from the subclass DatabricksConnection. The logic I added here is it will set the QueryTimeoutSeconds with 3 hours as long as it is not customized by the client with connection parameter adbc.apache.statement.query_timeout_s, which means even if it is configured by the base class with some other logic, it will still be overwritten with 3 hours.

@CurtHagenlocher CurtHagenlocher merged commit ebb2fd0 into apache:main Jul 18, 2025
8 checks passed
@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

+1 more reviewer

@jadewang-db jadewang-db jadewang-db approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 20

Development

Successfully merging this pull request may close these issues.

3 participants

@jackyhu-db @CurtHagenlocher @jadewang-db