fix(rust/core): fix build errror on windows and enable ci for windows #3148

eitsupi · 2025-07-13T15:08:18Z

adbc_snowflake tests for Windows fails so excluded.
Some tests of driver_manager are skipped because they fail for windows.

zeroshade · 2025-07-13T17:17:08Z

Welp, looks like I gotta fix the windows build code for the driver manager. ☹️

eitsupi · 2025-07-13T17:19:31Z

Apparently, use windows_sys as windows doesn't work!
Sorry...

eitsupi · 2025-07-13T17:22:32Z

CI is apparently working now, but the build is failing, so do I need to temporarily exclude windows-latest from the matrix so it can be merged?

zeroshade · 2025-07-13T17:24:02Z

Yea, let's temporarily exclude windows while I fix the windows build so we can merge this

eitsupi · 2025-07-13T17:35:45Z

let's temporarily exclude windows while I fix the windows build so we can merge this

Thanks!

I've excluded windows for now and opened a follow up issue #3149.

zeroshade · 2025-07-13T18:21:03Z

@eitsupi I've worked out the necessary changes to get it to build on windows. Should I push it to this PR or do you want to get this merged and I'll make a follow-up PR to enable the windows build with my changes?

eitsupi · 2025-07-13T18:28:30Z

That's so fast! Either is fine with me.
(I'm going to sleep now so I won't be able to reply for a while, so please feel free to edit this PR etc.)

zeroshade · 2025-07-13T23:42:38Z

Okay, so I've almost got this except for one weird linking issue with the rust adbc_snowflake crate on windows:

nowflake-0.natvis" "/NATVIS:C:\\Users\\zotth\\AppData\\Local\\Temp\\rustcbQbqD9\\adbc_snowflake-1.natvis"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: legacy_stdio_definitions.lib(legacy_stdio_definitions.obj) : warning LNK4078: multiple '.drectve' sections found with different attributes (00100A00)␍
          snowflake.lib(go.o) : fatal error LNK1223: invalid or corrupt file: file contains invalid .pdata contributions␍

I've hit a wall here. Any ideas @eitsupi @kou @lidavidm @paleolimbot ?

lidavidm · 2025-07-13T23:47:02Z

It's https://go-review.googlesource.com/c/go/+/678795

lidavidm · 2025-07-13T23:47:45Z

So I guess you can dynamically link Go libraries on Windows, but not statically.

zeroshade · 2025-07-13T23:55:54Z

sigh well, at least they found the issue and are fixing it, even though it'll be a while before we can use that fix. I guess we can disable the bundled feature on windows for now so that it doesn't do the static link

rust/driver/snowflake/build.rs

rust/core/src/driver_manager.rs

Co-authored-by: Matthijs Brobbel <[email protected]>

eitsupi · 2025-07-14T07:47:11Z

Thanks all! I'll take a look the build error.

eitsupi · 2025-07-14T08:31:01Z

Some tests are failing on Windows:

running 14 tests
test driver_manager::tests::test_get_search_paths ... ok
test driver_manager::tests::test_default_entrypoint ... FAILED
test driver_manager::tests::test_load_driver_env ... FAILED
test driver_manager::tests::test_load_absolute_path ... ok
test driver_manager::tests::test_load_absolute_path_no_ext ... ok
test driver_manager::tests::test_disallow_env_config ... FAILED
test driver_manager::tests::test_load_relative_path ... ok
test driver_manager::tests::test_load_driver_env_multiple_paths ... ok
test driver_manager::tests::test_load_non_ascii_path ... ok
test driver_manager::tests::test_manifest_missing_driver ... ok
test driver_manager::tests::test_manifest_wrong_arch ... ok
test driver_manager::tests::test_manifest_user_config ... FAILED
test ffi::types::tests::test_error_roundtrip ... ok
test ffi::types::tests::test_partitions_roundtrip ... ok

failures:

---- driver_manager::tests::test_default_entrypoint stdout ----

thread 'driver_manager::tests::test_default_entrypoint' panicked at core\src\driver_manager.rs:1887:13:
assertion `left == right` failed
  left: "AdbcLibadbcDriverSqliteInit"
 right: "AdbcDriverSqliteInit"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- driver_manager::tests::test_load_driver_env stdout ----

thread 'driver_manager::tests::test_load_driver_env' panicked at core\src\driver_manager.rs:1921:9:
assertion `left == right` failed
  left: Internal
 right: NotFound

---- driver_manager::tests::test_disallow_env_config stdout ----

thread 'driver_manager::tests::test_disallow_env_config' panicked at core\src\driver_manager.rs:1995:9:
assertion `left == right` failed
  left: Internal
 right: NotFound

---- driver_manager::tests::test_manifest_user_config stdout ----

thread 'driver_manager::tests::test_manifest_user_config' panicked at core\src\driver_manager.rs:2123:9:
assertion `left == right` failed
  left: Internal
 right: NotFound


failures:
    driver_manager::tests::test_default_entrypoint
    driver_manager::tests::test_disallow_env_config
    driver_manager::tests::test_load_driver_env
    driver_manager::tests::test_manifest_user_config

test result: FAILED. 10 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.21s

This reverts commit e799ae2.

This reverts commit bed74b7.

This reverts commit de2f189.

eitsupi · 2025-07-14T14:37:51Z

@zeroshade I was not able to fix the adbc_snowflake build error today. Also, I am currently skipping some tests of driver_manager.
Feel free to edit this PR as you did yesterday.
(However, since we are making a lot of progress compared to yesterday, I feel it is better to merge them anyway.)

zeroshade · 2025-07-14T14:47:30Z

I agree. Let's merge what we have and then open a new PR to continue fixing the windows tests.

eitsupi · 2025-07-14T14:54:26Z

Thanks!

ci(rust): enable tests on windows

2f79baf

eitsupi force-pushed the rust-ci-windows branch from cee4856 to 0714f9a Compare July 13, 2025 15:52

ci(rust): try using mamba on windows

f56b755

eitsupi force-pushed the rust-ci-windows branch from 0714f9a to f56b755 Compare July 13, 2025 15:56

ci: try conda instead of mamba

8272a24

eitsupi force-pushed the rust-ci-windows branch from 5849427 to 8272a24 Compare July 13, 2025 16:16

Merge branch 'main' into rust-ci-windows

167b22d

eitsupi marked this pull request as ready for review July 13, 2025 17:20

eitsupi requested review from lidavidm and zeroshade as code owners July 13, 2025 17:20

github-actions bot added this to the ADBC Libraries 20 milestone Jul 13, 2025

ci:(rust) exclude windows for now

8317bb7

eitsupi changed the title ~~ci(rust): enable tests on windows~~ ci(rust): add a job for tests on windows (excluded for now) Jul 13, 2025

eitsupi mentioned this pull request Jul 13, 2025

Rust: can't build adbc_core on windows #3149

Closed

fix windows build

536d96a

zeroshade requested a review from wjones127 as a code owner July 13, 2025 18:33

zeroshade added 2 commits July 13, 2025 16:32

fix linker on msvc

943567f

some dependency things

a13120e

fix lint

385d8eb

lidavidm approved these changes Jul 14, 2025

View reviewed changes

add lib for linking with MSVC

d2e7d9f

mbrobbel reviewed Jul 14, 2025

View reviewed changes

eitsupi marked this pull request as draft July 14, 2025 07:42

Apply suggestions from code review

981a89b

Co-authored-by: Matthijs Brobbel <[email protected]>

eitsupi changed the title ~~ci(rust): add a job for tests on windows (excluded for now)~~ fix(rust/core): fix build errror on windows and enable ci for windows Jul 14, 2025

ci: exclude snowflake test for windows for now

10cda1c

eitsupi added 4 commits July 14, 2025 08:35

test: skip some tests for windows for now

e799ae2

Revert "test: skip some tests for windows for now"

bed74b7

This reverts commit e799ae2.

ci: fix path on windows

e5f8f11

Reapply "test: skip some tests for windows for now"

b35b3e6

This reverts commit bed74b7.

eitsupi force-pushed the rust-ci-windows branch from dc8a7d0 to b35b3e6 Compare July 14, 2025 09:24

ci: exclude snowflake on windows in all steps

c0b8612

eitsupi marked this pull request as ready for review July 14, 2025 12:57

eitsupi force-pushed the rust-ci-windows branch from f0df569 to 10b0202 Compare July 14, 2025 13:05

refactor: address comments

2480db2

eitsupi force-pushed the rust-ci-windows branch from 10b0202 to 2480db2 Compare July 14, 2025 13:24

ci: try the snowflake linked feature on windows

de2f189

eitsupi force-pushed the rust-ci-windows branch from 42a3b37 to de2f189 Compare July 14, 2025 13:48

eitsupi added 2 commits July 14, 2025 14:05

Revert "ci: try the snowflake linked feature on windows"

b9a4c54

This reverts commit de2f189.

chore: add comments

ce963a5

zeroshade approved these changes Jul 14, 2025

View reviewed changes

zeroshade merged commit 442dce1 into apache:main Jul 14, 2025
8 checks passed

eitsupi deleted the rust-ci-windows branch July 14, 2025 14:54

serramatutu mentioned this pull request Aug 12, 2025

Sync upstream dbt-labs/arrow-adbc#52

Closed

fix(rust/core): fix build errror on windows and enable ci for windows #3148

fix(rust/core): fix build errror on windows and enable ci for windows #3148

Uh oh!

Conversation

eitsupi commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zeroshade commented Jul 13, 2025

Uh oh!

eitsupi commented Jul 13, 2025

Uh oh!

eitsupi commented Jul 13, 2025

Uh oh!

zeroshade commented Jul 13, 2025

Uh oh!

eitsupi commented Jul 13, 2025

Uh oh!

zeroshade commented Jul 13, 2025

Uh oh!

eitsupi commented Jul 13, 2025

Uh oh!

zeroshade commented Jul 13, 2025

Uh oh!

lidavidm commented Jul 13, 2025

Uh oh!

lidavidm commented Jul 13, 2025

Uh oh!

zeroshade commented Jul 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eitsupi commented Jul 14, 2025

Uh oh!

eitsupi commented Jul 14, 2025

Uh oh!

eitsupi commented Jul 14, 2025

Uh oh!

zeroshade commented Jul 14, 2025

Uh oh!

Uh oh!

eitsupi commented Jul 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eitsupi commented Jul 13, 2025 •

edited

Loading