fix(go/adbc/drivermgr): properly vendor toml++ #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
commented
Jul 11, 2025
Member
Author
zeroshade
left a comment
zeroshade
left a comment
There was a problem hiding this comment.
Thanks @Mandukhai-Alimaa for finding this!
lidavidm
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
drivermgrpackage referenced the c/vendor directory in the CGO building which doesn't work as that isn't within the Go module itself and wouldn't get included when the module is served as a dependency. We need to properly vendor the toml++ header file in the Go source so that it is delivered and packaged with the module properly.