Skip to content

Conversation

@jackyhu-db
Copy link
Contributor

Motivation

The default value of GetObjectsPatternsRequireLowerCase of DatabricksConnection is false (inherit from SparkConnection, see here), so when it is called with table pattern in uppercase as below, it does not return all the tables start with test and fails some test cases DriverTest:GetObjectsTablesTest (when tableNamePattern is uppercase)

Connection.GetObjects(
                    depth: AdbcConnection.GetObjectsDepth.Tables,
                    catalogPattern = "catalog1",
                    dbSchemaPattern = "default",
                    tableNamePattern = "TEST%");

Changes

  • Override GetObjectsPatternsRequireLowerCase to true in DatabricksConnection

Test

Apache.Arrow.Adbc.Tests.Drivers.Databricks.DriverTests.CanGetObjectsTables

@github-actions github-actions bot added this to the ADBC Libraries 20 milestone Jul 10, 2025
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is complaining about a line-ending.

@CurtHagenlocher CurtHagenlocher merged commit a56528c into apache:main Jul 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants