fix(go/adbc/pkg): add PowerShell option to run when executing in a Windows-based ADO pipeline #3124
Conversation
|
@zeroshade - we verified this against the ADO pipeline. Can you verify it doesn't mess up anything with the versioning that you did for the Go drivers? |
| RM=del | ||
| GIT_VERSION=$(shell powershell -Command "git tag --sort=-v:refname --points-at $(git rev-list --tags --max-count=1) | Select-Object -First 1") | ||
| else | ||
| SUFFIX=dylib |
There was a problem hiding this comment.
Doesn't this omit macOS? Maybe there should be a separate ifeq windows [powershell] else [git]?
There was a problem hiding this comment.
good catch. fixed.
There was a problem hiding this comment.
@davidhcoe as long as that powershell command returns the same "go/adbc/v#.#.#" string that we get from on Linux/unix then it shouldn't cause any issues with the version embedding.
I'm not familiar with the ?= syntax in makefiles, but I assume it's essentially that it assigns iff it's currently empty/unset, right? If so, all should be good.
|
I need to run 1 more pipeline test to verify again after my recent push. |
|
ok, all set. The PowerShell output looks like: |
|
Looks good! |
3 participants
When running from the PowerShell script as part of an ADO pipeline, the line
was generating the error:
This change swaps some of the commands but also has a separate PowerShell command for the Windows OS instead of the shell command.