feat(go/adbc/sqldriver): handle timestamp/time.Time values for input #3109
Conversation
lidavidm
changed the title
go/adbc/sqldriver/driver.go
Outdated
| buffers = append(buffers, memory.NewBufferBytes(buf)) | ||
| case arrow.Time32: | ||
| if dt == nil || dt.ID() != arrow.TIME32 { | ||
| panic(errors.New("can only create array from arrow.Time32 with known type")) |
There was a problem hiding this comment.
Instead of panicking, I think we should propagate the error upwards
There was a problem hiding this comment.
It might also be better to say something like "can only create array from ... when statement is prepared and server provides parameter schema"
There was a problem hiding this comment.
We would only run into the issue when they try to execute with the passed in params, not when it is prepared. The issue is if they pass an arrow.Time32 when the server didn't provide a parameter schema, we don't know what type this should be (because of the time unit).
That said, it's easy enough to propagate the error upwards instead of panicking, which i'll do.
There was a problem hiding this comment.
Right, I'm suggesting that the error message should say what they need to do
2 participants
fixes #3103
Adding new cases to
arrFromValto allow for handlingtime.Timeandarrow.Timestampandarrow.Time32/arrow.Time64types. This only works when the parameter schema is provided by the FlightSQL server side when utilizing a prepared statement or otherwise.If we don't have the parameter schema, then it will error as usual.