fix(csharp/src/Drivers/Databricks): Set the SqlState of the exception in RetryHttpHandler #3092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtHagenlocher
requested changes
Jul 3, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! Can you set the SqlState on the exception explicitly? (This may or may not remove the need to also add it to the message.)
|
|
||
| throw new DatabricksException( | ||
| lastErrorMessage ?? "Service temporarily unavailable and retry timeout exceeded", | ||
| "[SQLState: 08001]" + (lastErrorMessage ?? "Service temporarily unavailable and retry timeout exceeded"), |
Contributor
There was a problem hiding this comment.
There's a separate field on DatabricksException for SqlState. It's not in the constructor, but you can do
throw new DatabricksException(...).SetSqlState("08001");
I don't know if that would also make the message come out correctly where you want it to, but having the SqlState as a property without having to parse it out of the message is definitely a good thing.
Contributor
Author
There was a problem hiding this comment.
Thanks. It makes sense and I uploaded the patch to fix it.
jackyhu-db
changed the title
CurtHagenlocher
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Description
This PR set the
SqlStateof the timeout exception raised in DatabricksRetryHttpHandlerto align SqlState used in same exception in other Databricks drivers including JDBC.Changes
SqlStateof the timeout exception raised in DatabricksRetryHttpHandlerRetryHttpHandlerTestMotivation
Fix the failure in unit test
RetryHttpHandlerTestand align the error message with other Databricks drivers.Testing