fix(csharp/src/Drivers/Databricks): Align ConnectionTimeout with TemporarilyUnavailableRetryTimeout #3073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyhu-db
changed the title
CurtHagenlocher
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Description
This PR sets the
ConnectTimeoutMillisecondsofDatabricksConnectionwithTemporarilyUnavailableRetryTimeoutwhenTemporarilyUnavailableRetryTimeoutis greater thanConnectTimeoutMillisecondsto make sure it can continue the retry whenConnectTimeoutMillisecondsis lower thanTemporarilyUnavailableRetryTimeout.Changes
DatabricksConnection:ValidateOptionsto setConnectTimeoutMillisecondswithTemporarilyUnavailableRetryTimeoutwhenTemporarilyUnavailableRetryTimeoutis greater thanConnectTimeoutMillisecondsandTemporarilyUnavailableRetryis enabledMotivation
The default value of
ConnectTimeoutMillisecondsis 30 seconds (see here), which is lower than the default value (900s) ofTemporarilyUnavailableRetryTimeout. If client does not set this, it will timeout after 30s, this is normally lower than the Databricks cluster startup time, so the client/user may get the timeout error when opening a connection on an idle cluster.Testing