Skip to content

feat(python/adbc_driver_manager): accept pathlib.Path in Database #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 1 commit into from
Jun 27, 2025
Merged

feat(python/adbc_driver_manager): accept pathlib.Path in Database #3035

lidavidm merged 1 commit into from
Jun 27, 2025

Conversation

@lidavidm
Copy link
Member

@lidavidm lidavidm commented Jun 27, 2025

Fixes #3007.

@lidavidm lidavidm marked this pull request as ready for review June 27, 2025 03:00
@github-actions github-actions bot added this to the ADBC Libraries 19 milestone Jun 27, 2025
kou
kou approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lidavidm lidavidm merged commit 900fe52 into apache:main Jun 27, 2025
57 of 63 checks passed
@lidavidm lidavidm deleted the gh-3007 branch June 27, 2025 03:23
@kou
Copy link
Member

kou commented Jun 27, 2025

Hmm. This might break CI: https://github.com/apache/arrow-adbc/actions/runs/15918511789/job/44900698748?pr=3041#step:19:12

/Users/runner/work/arrow-adbc/arrow-adbc/python/adbc_driver_manager/tests/test_dbapi.py
  /Users/runner/work/arrow-adbc/arrow-adbc/python/adbc_driver_manager/tests/test_dbapi.py:488:35 - error: Argument of type "Path" cannot be assigned to parameter "driver" of type "str" in function "connect"
    "Path" is not assignable to "str" (reportArgumentType)
/Users/runner/work/arrow-adbc/arrow-adbc/python/adbc_driver_manager/tests/test_lowlevel.py
  /Users/runner/work/arrow-adbc/arrow-adbc/python/adbc_driver_manager/tests/test_lowlevel.py:475:20 - error: Argument of type "Path" cannot be assigned to parameter "driver" of type "str" in function "__init__"
    "Path" is not assignable to "str" (reportArgumentType)

@kou kou mentioned this pull request Jun 27, 2025
Closed
@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 19

Development

Successfully merging this pull request may close these issues.

python/adbc_driver_manager: accept Path for AdbcDatabase's driver param

2 participants

@lidavidm @kou