Skip to content

fix(csharp/src/Drivers/BigQuery): Prevent callers from attempting to use the public project ID to create query jobs #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CurtHagenlocher merged 1 commit into from
Jun 16, 2025
Merged

fix(csharp/src/Drivers/BigQuery): Prevent callers from attempting to use the public project ID to create query jobs #2966

CurtHagenlocher merged 1 commit into from
Jun 16, 2025

Conversation

@davidhcoe
Copy link
Contributor

@davidhcoe davidhcoe commented Jun 15, 2025

In some situations, the publicProjectId gets passed as the actual project ID and causes an error when we try to create a query job:

    Google.GoogleApiException : The service bigquery has thrown an exception. HttpStatusCode is Forbidden.
     Access Denied: Project bigquery-public-data: User does not have bigquery.jobs.create permission in
     project bigquery-public-data.

This PR adds a check for the public project ID and treats it as if we need to detect the project ID for the caller.

@github-actions github-actions bot modified the milestone: ADBC Libraries 19 Jun 15, 2025
@davidhcoe
Copy link
Contributor Author

davidhcoe commented Jun 15, 2025 •
edited
Loading

Only a new environment configuration was needed to validate this using the DriverTests.CanExecuteQuery test:

"PublicIdTest": {
  "description": "Test using the public project ID",
  "clientId": "$ref:shared.clientId",
  "clientSecret": "$ref:shared.clientSecret",  
  "refreshToken": "$ref:shared.refreshToken",
  "tokenEndpoint": "$ref:shared.tokenEndpoint",
  "includePublicProjectIds": true,
  "queryTimeout": 420,
  "projectId": "bigquery-public-data",
  "query": "SELECT * FROM bigquery-public-data.austin_bikeshare.bikeshare_stations",
  "expectedResults": 101,
  ...
}

@CurtHagenlocher CurtHagenlocher merged commit be46fe5 into apache:main Jun 16, 2025
7 checks passed
@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
@davidhcoe davidhcoe deleted the dev/bq-projectid-fix branch October 24, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 19

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhcoe @CurtHagenlocher