fix(csharp/src/Drivers): Enhance pattern wildcard escaping in metadata operations #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wang-1990
changed the title
…csharp-enhance-pattern-wildcard-escaping
eric-wang-1990
changed the title
…csharp-enhance-pattern-wildcard-escaping
CurtHagenlocher
requested changes
Jun 19, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! One small comment/request for change.
| EscapeUnderscoreInName(TableName), | ||
| (CatalogName), | ||
| (SchemaName), | ||
| (TableName), |
Contributor
There was a problem hiding this comment.
Was this supposed to be changed to EscapePatternWildcardsInName or does this Thrift API not work with wild cards? If the latter, then please remove the parens from the arguments.
Contributor
There was a problem hiding this comment.
Oh, I see in the other PR that this doesn't need wildcards and the parens are removed there. In any event, these would need to be removed to avoid a merge conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Why
Power BI ODBC path do escape both _ and %:
Proposed changes
This PR improves the handling of SQL pattern wildcards in metadata operations for C# drivers:
EscapeUnderscoreparameter toEscapePatternWildcardsto better reflect its purpose_) and percent (%) charactersDatabricksConnection.cswhere default namespace was not being set correctlyHow this was tested
Additional context
SQL pattern matching uses underscores (
_) and percent signs (%) as wildcards. When searching for tables or columns that contain these characters literally, they need to be escaped. Previously, we only handled escaping underscores, but this change extends the functionality to handle percent signs as well, providing more complete support for SQL pattern matching.