fix(c/driver/postgresql): ingest zoned timestamp as WITH TIME ZONE #2904
Conversation
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
No code notes from me, but conceptually, do we actually want this? If a user inserts data with America/Halifax and the timezone of the database is America/Phoenix, the timezone is still not really preserved because the database will return America/Phoenix?
|
Ah, I will do some more testing...but I think zoned timestamps should be preserved as zoned timestamps (even if the actual metadata isn't preserved) |
|
Got it. No strong preference either way since the point in time is correct, just noting that we're substituting an arbitrary time zone in place of a type that we can at least predict. |
|
Ah, sorry, I'd forgotten that timezone of "" makes it timezone unaware, not UTC. Ignore me! |
|
Added another test in Python, just to confirm that we don't need to reset the timezone before a bulk COPY (interestingly enough). |
2 participants
Fixes #2901.