feat(csharp/src/Drivers/Databricks): Add configurable multiple catalog support #2845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g support Adds a new connection parameter 'adbc.databricks.enable_multiple_catalog_support' to control whether the driver should use multiple catalogs or restrict to a default catalog. Default is true for backward compatibility. This parameter accepts boolean values 'true'/'false' or '1'/'0' for compatibility with tools like PowerBI.
eric-wang-1990
changed the title
CurtHagenlocher
requested changes
May 27, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! Is there a reason not to use "true" and "false" instead of "0" and "1" in the connection string?
| { | ||
| _enableMultipleCatalogSupport = enableMultipleCatalogSupportValue; | ||
| } | ||
| // PowerBI will pass in "1" and "0" as strings, so we need to handle that |
Contributor
There was a problem hiding this comment.
The ADBC convention is to use "true" and "false" for boolean-valued settings. Is it important to retain compatibility with ODBC here? The property name will be different anyway.
Contributor
Author
There was a problem hiding this comment.
The existing Power BI connector passed in "0", "1" etc, do you recommend changing the connector code to overwrite as true/false rather than handle here in the driver?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring multiple catalog behavior in the C# Databricks ADBC driver. It introduces a new connection parameter
adbc.databricks.enable_multiple_catalog_supportthat allows users to control whether the driver should use multiple catalogs or restrict to a default catalog.Proposed Changes
adbc.databricks.enable_multiple_catalog_supportto control multiple catalog behaviorHow is this tested?
Added unit tests that verify the behavior of metadata queries (GetSchemas, GetTables) with different settings of the
CanUseMultipleCatalogsparameter. Tests confirm that when disabled, only the default catalog is used, and when enabled, multiple catalogs can be accessed.