feat(csharp/src/Drivers/Apache): Add support for Sasl transport in Hive and Impala ADBC Driver #2822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kushaman
commented
May 13, 2025
kushaman
commented
- Added support of SASL transport in thrift folder.
- Implemented PLAIN mechanism in SASL transport
- Added HiveServer2StandardConnection to support binary transport mode.
- Used SASL transport in Hiveserver2 standard connection with basic auth.
CurtHagenlocher
requested changes
May 13, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! Are you also planning to add some test code?
Contributor
|
The linter is also complaining about some trailing whitespace and some mixed (LF vs CRLF) line endings. |
kushaman
changed the title
Contributor
Author
|
We already have test code present already for Hive and Impala. |
CurtHagenlocher
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.