Skip to content

Conversation

@toddmeng-db
Copy link
Contributor

@toddmeng-db toddmeng-db commented May 13, 2025

Uses GetOperationStatus Polling to guarantee that query/command results stays alive after query execution has completed. DatabricksReader and CloudFetchReaders start async loops that send Pings every minute, until the results have been completely consumed or the connection closes.

Includes Unit tests + an e2e testing for query stays alive more than 20 mins.

@toddmeng-db toddmeng-db force-pushed the toddmeng-db/heartbeat-retrieval branch from 670f383 to ef3bfc2 Compare May 13, 2025 05:35
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("Apache.Arrow.Adbc.Drivers.Databricks, PublicKey=0024000004800000940000000602000000240000525341310004000001000100e504183f6d470d6b67b6d19212be3e1f598f70c246a120194bc38130101d0c1853e4a0f2232cb12e37a7a90e707aabd38511dac4f25fcb0d691b2aa265900bf42de7f70468fc997551a40e1e0679b605aa2088a4a69e07c117e988f5b1738c570ee66997fba02485e7856a49eca5fd0706d09899b8312577cbb9034599fc92d4")]
[assembly: InternalsVisibleTo("Apache.Arrow.Adbc.Tests.Drivers.Databricks, PublicKey=0024000004800000940000000602000000240000525341310004000001000100e504183f6d470d6b67b6d19212be3e1f598f70c246a120194bc38130101d0c1853e4a0f2232cb12e37a7a90e707aabd38511dac4f25fcb0d691b2aa265900bf42de7f70468fc997551a40e1e0679b605aa2088a4a69e07c117e988f5b1738c570ee66997fba02485e7856a49eca5fd0706d09899b8312577cbb9034599fc92d4")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to expose some of the internal classes to Moq

@toddmeng-db toddmeng-db changed the title heartbeat service impl feat(csharp/src/Drivers/Databricks): Heartbeat service impl May 15, 2025
@toddmeng-db toddmeng-db force-pushed the toddmeng-db/heartbeat-retrieval branch 2 times, most recently from d298d41 to 11f86ff Compare May 15, 2025 22:59
@toddmeng-db toddmeng-db force-pushed the toddmeng-db/heartbeat-retrieval branch 3 times, most recently from f50a47e to 7ed23e4 Compare May 15, 2025 23:33
@toddmeng-db toddmeng-db force-pushed the toddmeng-db/heartbeat-retrieval branch from 7ed23e4 to 1670878 Compare May 15, 2025 23:40
@toddmeng-db toddmeng-db changed the title feat(csharp/src/Drivers/Databricks): Heartbeat service impl feat(csharp/src/Drivers/Databricks): Poll Status to keep query alive May 16, 2025
@toddmeng-db toddmeng-db changed the title feat(csharp/src/Drivers/Databricks): Poll Status to keep query alive feat(csharp/src/Drivers/Databricks): Poll status to keep query alive May 16, 2025
@toddmeng-db toddmeng-db force-pushed the toddmeng-db/heartbeat-retrieval branch from 0d52db3 to 62a35d4 Compare May 16, 2025 21:59
@toddmeng-db toddmeng-db force-pushed the toddmeng-db/heartbeat-retrieval branch from 62a35d4 to 055b723 Compare May 16, 2025 22:07
@toddmeng-db toddmeng-db marked this pull request as ready for review May 16, 2025 22:07
@github-actions github-actions bot added this to the ADBC Libraries 19 milestone May 16, 2025
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit 4d78ff7 into apache:main May 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants