Skip to content

feat(csharp/src/Drivers/Databricks): OAuthClientCredentialsProvider test improvements #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CurtHagenlocher merged 1 commit into from
May 8, 2025
Merged

feat(csharp/src/Drivers/Databricks): OAuthClientCredentialsProvider test improvements #2799

CurtHagenlocher merged 1 commit into from
May 8, 2025

Conversation

@toddmeng-db
Copy link
Contributor

@toddmeng-db toddmeng-db commented May 8, 2025 •
edited
Loading

Some simple improvements for the OAuthClientCredentialsProvider tests.

  1. Users can use uri OR hostname parameter while running this test.
  2. Tests expired token triggers a refetch for a non-expired token.

To test out, set DATABRICKS_TEST_CONFIG_FILE environment variable to some json file with the following fields:

  "uri": "...", // can use hostname too
  "client_id": "...",
  "client_secret": "...",

@toddmeng-db toddmeng-db force-pushed the toddmeng-db/oauth-expiration-refresh-test branch from a36d052 to 3bd34fd Compare May 8, 2025 17:03
@toddmeng-db toddmeng-db changed the title Add test case for OAuth token expiration feat(csharp/src/Drivers/Databricks): OAuthClientCredentials provider testing May 8, 2025
@toddmeng-db toddmeng-db changed the title feat(csharp/src/Drivers/Databricks): OAuthClientCredentials provider testing feat(csharp/src/Drivers/Databricks): OAuthClientCredentials provider test improvements May 8, 2025
@toddmeng-db toddmeng-db marked this pull request as ready for review May 8, 2025 17:17
@toddmeng-db toddmeng-db changed the title feat(csharp/src/Drivers/Databricks): OAuthClientCredentials provider test improvements feat(csharp/src/Drivers/Databricks): OAuthClientCredentialsProvider test improvements May 8, 2025
@github-actions github-actions bot added this to the ADBC Libraries 19 milestone May 8, 2025
CurtHagenlocher
CurtHagenlocher approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit f6c1019 into apache:main May 8, 2025
12 of 16 checks passed
@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 19

Development

Successfully merging this pull request may close these issues.

2 participants

@toddmeng-db @CurtHagenlocher