Skip to content

fix(r/adbcsnowflake): Fix configuration of adbcsnowflake when configure is run from a git shell #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 1 commit into from
May 3, 2025
Merged

fix(r/adbcsnowflake): Fix configuration of adbcsnowflake when configure is run from a git shell #2771

lidavidm merged 1 commit into from
May 3, 2025

Conversation

@paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented May 2, 2025

Closes #2767

It seems like the RTools shell identifies itself as MSYS_NT... whereas the git shell identifies itself as MINGW64_NT.... It looks like r-universe configures using the git shell? We can support both!

@paleolimbot paleolimbot mentioned this pull request May 2, 2025
Closed
@lidavidm
Copy link
Member

lidavidm commented May 3, 2025

Ah, sorry, I cut the release before I saw these PRs...

@lidavidm lidavidm merged commit f9c28b1 into apache:main May 3, 2025
26 checks passed
@lidavidm lidavidm added this to the ADBC Libraries 19 milestone May 3, 2025
@jeroen
Copy link
Contributor

jeroen commented May 3, 2025 •
edited
Loading

It seems like the RTools shell identifies itself as MSYS_NT...

For reference, this depends on how you start msys2. Any msys2 installation can be started in different modes, which have separate shells and icons, and different compilers and uname.

The MSYS mode is intended to build executables for use by msys2 itself; the resulting binaries depend on the msys2 runtime and will not work other windows systems. To compile software with mingw64 that can run on any windows system without msys2 (as R does) you need start msys2 in MINGW64 mode.

img

@paleolimbot
Copy link
Member Author

paleolimbot commented May 5, 2025

Ah, sorry, I cut the release before I saw these PRs...

No worries! The timing was unrelated 🙂

For reference, this depends on how you start msys2

Thanks for the background!

@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 19

Development

Successfully merging this pull request may close these issues.

R: bug in configure test detecting OS

3 participants

@paleolimbot @lidavidm @jeroen