Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Apr 30, 2025

This PR is a bit of a check on my understanding. There are a few changes here:

  1. Changed first sentence to help draw the reader in a bit better.
  2. Changes the language "a set of abstract APIs" around. Is it more accurate to say there's one abstract API and that there are interface definitions in a few languages, most recently including Rust?
  3. Remove the "For example..." as it felt out of place and slows the reader down from getting to bullet point 2.
  4. Instead of referencing an easily out of date list of implementations, just link to the driver status page.

@amoeba amoeba requested a review from lidavidm as a code owner April 30, 2025 20:07
@github-actions github-actions bot added this to the ADBC Libraries 18 milestone Apr 30, 2025
@amoeba
Copy link
Member Author

amoeba commented Apr 30, 2025

I'll note that, depending on the answer to my second point, I can file follow-up PRs to pages like https://arrow.apache.org/adbc/main/format/specification.html to update those.

@lidavidm
Copy link
Member

I guess we never really nailed down what is the "canonical" API. The C header is "most canonical", and I've been treating Java/Go like that as well, but also Java/Go make it much easier to make backwards-compatible changes so we can be more free than we can be with C. And I'm not sure Rust or C# are ready to be included there, but could be in principle.

@lidavidm
Copy link
Member

Maybe just omit listing languages altogether? :)

@amoeba
Copy link
Member Author

amoeba commented May 1, 2025

Thanks for taking a look. I re-worked the language a bit:

  • Reworded "ADBC is a standard" to "ADBC is the standard" since I like that better
  • From bullet point 1, removed specific mention of languages

How does that look?

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit e869a55 into apache:main May 1, 2025
26 checks passed
colin-rogers-dbt pushed a commit to dbt-labs/arrow-adbc that referenced this pull request Jun 10, 2025
This PR is a bit of a check on my understanding. There are a few changes
here:

1. Changed first sentence to help draw the reader in a bit better.
2. Changes the language "a set of abstract APIs" around. Is it more
accurate to say there's one abstract API and that there are interface
definitions in a few languages, most recently including Rust?
3. Remove the "For example..." as it felt out of place and slows the
reader down from getting to bullet point 2.
4. Instead of referencing an easily out of date list of implementations,
just link to the driver status page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants