feat: Declare dependencies for drivers in Meson configuration #2746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Apr 28, 2025
| filebase: 'adbc-driver-bigquery', | ||
| ) | ||
|
|
||
| adbc_driver_bigquery_dep = declare_dependency( |
Contributor
Author
There was a problem hiding this comment.
We can name these dependencies whatever we want. I've stuck with this pattern, but instead of adbc_driver_bigquery perhaps adbc_bigquery_driver or just adbc_bigquery would be more "user friendly"
WillAyd
force-pushed
the
meson-dependency-per-driver
branch
from
1320ea1 to
51e22df
Compare
WillAyd
force-pushed
the
meson-dependency-per-driver
branch
from
51e22df to
9e92fe1
Compare
lidavidm
approved these changes
Apr 28, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Maybe down the line we should add a CI test for it
colin-rogers-dbt
pushed a commit
to dbt-labs/arrow-adbc
that referenced
this pull request
Jun 10, 2025
…che#2746) These don't impact arrow-adbc directly, but are theoretically helpful for downstream projects that might want to use ADBC dependencies from source. With this, on the next release I think we could add arrow-adbc to Meson's wrap database, and give users the option of something as simple as running: ```bash meson wrap install adbc ``` To fetch adbc as a subproject. With that, users could then do: ```python adbc_bigquery_driver_dep = dependency('adbc_bigquery_driver') myexc = executable( 'some-executable', sources: [...], dependencies: [adbc_bigquery_driver_dep], ) ``` To have Meson automatically compile and link the executable to the appropriate driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These don't impact arrow-adbc directly, but are theoretically helpful for downstream projects that might want to use ADBC dependencies from source.
With this, on the next release I think we could add arrow-adbc to Meson's wrap database, and give users the option of something as simple as running:
To fetch adbc as a subproject. With that, users could then do:
To have Meson automatically compile and link the executable to the appropriate driver