Skip to content

fix(csharp/src/Drivers/BigQuery): TIME should be Time64Type.Microsecond #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CurtHagenlocher merged 7 commits into from
May 6, 2025
Merged

fix(csharp/src/Drivers/BigQuery): TIME should be Time64Type.Microsecond #2741

CurtHagenlocher merged 7 commits into from
May 6, 2025

Conversation

@davidhcoe
Copy link
Contributor

@davidhcoe davidhcoe commented Apr 23, 2025 •
edited
Loading

@github-actions github-actions bot added this to the ADBC Libraries 18 milestone Apr 23, 2025
@davidhcoe davidhcoe marked this pull request as draft April 23, 2025 17:18
@davidhcoe davidhcoe changed the title fix(csharp/src/Apache.Arrow.Adbc/Extensions): fix Time conversion fix(csharp/src/Drivers/BigQuery): TIME should be Time64Type.Microsecond May 6, 2025
@davidhcoe davidhcoe marked this pull request as ready for review May 6, 2025 14:08
CurtHagenlocher
CurtHagenlocher requested changes May 6, 2025
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you make two small formatting changes?

csharp/src/Client/SchemaConverter.cs
row[SchemaTableColumn.NumericScale] = decimal32Type.Scale;
}
else if (f.DataType is Decimal128Type decimal64Type)
else if (f.DataType is Decimal64Type decimal64Type)
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derp

CurtHagenlocher
CurtHagenlocher approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit eee8bca into apache:main May 6, 2025
6 checks passed
@serramatutu serramatutu mentioned this pull request Aug 12, 2025
Closed
@davidhcoe davidhcoe deleted the dev/time-parse-fix branch October 24, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 19

Development

Successfully merging this pull request may close these issues.

C#/ADBC/driver/googlebigquery: The time type data cannot be read correctly

3 participants

@davidhcoe @CurtHagenlocher @lidavidm