fix(go/adbc/driver/snowflake): implement ability to set database options after initialization #2728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrv
changed the title
felipecrv
force-pushed
the
set-option-snowflake
branch
from
2569445 to
647d42f
Compare
lidavidm
reviewed
Apr 22, 2025
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM
Please update the PR description, it seems this does a few other minor things beyond just implementing PostInitOptions
Comment on lines
181
to
182
| // cnOptions() is nil is SetOptionInternal() is being called when setting an | ||
| // option post-initialization. |
Member
There was a problem hiding this comment.
Can you reword this? It's not immediately obvious what it's trying to say. (cnOptions is nil if the option is being set post-initialiation. perhaps)
Contributor
Author
There was a problem hiding this comment.
yeah, the typo... I'm copying your line.
felipecrv
commented
Apr 23, 2025
Contributor
Author
I guess you're referring to the addition of |
lidavidm
approved these changes
Apr 23, 2025
colin-rogers-dbt
pushed a commit
to dbt-labs/arrow-adbc
that referenced
this pull request
Jun 10, 2025
…ons after initialization (apache#2728) I had to move the initialization of the `defaultAppName` to the `databaseImpl` instance to be able to use it when setting options post initialization. Fixes apache#2727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to move the initialization of the
defaultAppNameto thedatabaseImplinstance to be able to use it when setting options post initialization.Fixes #2727