feat(go/adbc/driver/bigquery): Return data about table/view partitioning #2697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is there anything in the unit tests for these? If not, is it reasonable/possible to add anything for it? |
This prevents the driver from panicking.
felipecrv
force-pushed
the
felipe/bq-partitions
branch
from
290f314 to
9eb9ad1
Compare
Contributor
Author
The code doesn't seem very unit testable without actually connecting to a BigQuery server, creating a partitioned table/view and then inspecting the metadata. {"MaterializedView.AllowNonIncrementalDefinition": "false",
"MaterializedView.Query": "SELECT * FROM test_felipecrv.a",
"Location": "US", "TimePartitioning.Type": "MONTH", "Labels": "",
"TimePartitioning.Expiration": "72h0m0s", "NumRows": "0",
"NumBytes": "0", "ETag": "6RLDXSGfrJqAc2nJ1GFHhg==",
"FullID": "....:felipecrv.b_materialized_view",
"MaterializedView.RefreshInterval": "30m0s", "NumLongTermBytes": "0", "Description": "",
"Type": "MATERIALIZED_VIEW",
"MaterializedView.EnableRefresh": "true",
"LastModifiedTime":
"2025-04-10T14:10:27.685-07:00",
"CreationTime": "2025-04-10T14:10:15.492-07:00",
"Name": "",
"TimePartitioning.Field": "txn_date",
"MaterializedView.LastRefreshTime": "2025-04-10T14:10:15.694-07:00",
"DefaultCollation": ""} |
Member
|
@felipecrv yea, for example our snowflake tests actually make snowflake requests. I'm not aware of anything that can mock BigQuery so we might need to actually add credentials to connect to bigquery. I'm okay with leaving that out of this then. |
zeroshade
approved these changes
Apr 11, 2025
felipecrv
added a commit
to dbt-labs/arrow-adbc
that referenced
this pull request
Apr 11, 2025
felipecrv
added a commit
to dbt-labs/arrow-adbc
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.