Skip to content

Conversation

@eric-wang-1990
Copy link
Contributor

This PR 9ba6bdb introduce a regression for DatabricksReader.
Fix it, also remove the unneeded constructor to prevent any misuse in the future.

@github-actions github-actions bot added this to the ADBC Libraries 18 milestone Apr 9, 2025
@eric-wang-1990 eric-wang-1990 changed the title fix(chsarp/src/Drivers) Fix Lz4 compression logic for DatabricksReader fix(chsarp/src/Drivers): Fix Lz4 compression logic for DatabricksReader Apr 9, 2025
@eric-wang-1990 eric-wang-1990 changed the title fix(chsarp/src/Drivers): Fix Lz4 compression logic for DatabricksReader fix(chsarp/src/Drivers/Databricks): Fix Lz4 compression logic for DatabricksReader Apr 9, 2025
@eric-wang-1990 eric-wang-1990 changed the title fix(chsarp/src/Drivers/Databricks): Fix Lz4 compression logic for DatabricksReader fix(csharp/src/Drivers/Databricks): Fix Lz4 compression logic for DatabricksReader Apr 10, 2025
@davidhcoe
Copy link
Contributor

What indicated this was not working? Was

public async Task LZ4DecompressionCapabilityTest(bool useCloudFetch, string configName)
failing and now it is passing with this change, or something else?

@eric-wang-1990
Copy link
Contributor Author

What indicated this was not working? Was

public async Task LZ4DecompressionCapabilityTest(bool useCloudFetch, string configName)

failing and now it is passing with this change, or something else?

Yes

@CurtHagenlocher CurtHagenlocher merged commit 5465573 into apache:main Apr 14, 2025
6 of 10 checks passed
colin-rogers-dbt pushed a commit to dbt-labs/arrow-adbc that referenced this pull request Jun 10, 2025
…abricksReader (apache#2690)

This PR
apache@9ba6bdb
introduce a regression for DatabricksReader.
Fix it, also remove the unneeded constructor to prevent any misuse in
the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants