fix(csharp/src/Drivers/Apache): Set tls enabled to true all HTTP-based drivers, by default #2667
Conversation
|
My overall feedback before going into any individual details is that I don't think this change is correct. It might be true that there are Spark services such as Databricks or HDInsight (does that even still exist) which are always managed and for which these options are not worthwhile, but it's also true that anyone can stand up a Spark instance for which they might need to set these properties. It does not make sense to limit this driver in ways that won't work for that case. |
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround! As per my other comment, I don't think this is the right approach to solving the problem.
birschick-bq
changed the title
@CurtHagenlocher - TLS enabled is now default for all HTTP-based drivers. |
…d drivers, by default (apache#2667) This change fixes a problem when connecting to a Databricks data source using the `adbc.hive.host` and `adbc.hive.path` instead of `uri`. Databricks connections always require an encrypted connection, so the default of `false` for option `adbc.http_options.tls.enabled` does not correctly apply to a Databricks connection. This change makes the default `True` for Databricks and all HTTP-based drivers. Callers can provide a `uri` with `http:` scheme or set the `adbc.http_options.tls.enabled` to `False` to disable TLS communication. Further, there are improvements in the test environment to support all options in the `http_options.tls.*` namespace
2 participants
This change fixes a problem when connecting to a Databricks data source using the
adbc.hive.hostandadbc.hive.pathinstead ofuri.Databricks connections always require an encrypted connection, so the default of
falsefor optionadbc.http_options.tls.enableddoes not correctly apply to a Databricks connection. This change makes the defaultTruefor Databricks and all HTTP-based drivers. Callers can provide auriwithhttp:scheme or set theadbc.http_options.tls.enabledtoFalseto disable TLS communication.Further, there are improvements in the test environment to support all options in the
http_options.tls.*namespace