fix(c/driver/postgresql): avoid crash if closing invalidated result #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver does not prevent you from closing a statement when there is still an open result set. Then closing the result set would crash. Avoid this by having the result set keep a weak pointer to the actual state. Fixes apache#2629.
zeroshade
approved these changes
Mar 27, 2025
paleolimbot
approved these changes
Mar 27, 2025
Comment on lines
+223
to
+225
| struct ExportedTupleReader { | ||
| std::weak_ptr<TupleReader> self; | ||
| }; |
Member
There was a problem hiding this comment.
Can you add a comment about what this is doing (or maybe just link the issue?).
colin-rogers-dbt
pushed a commit
to dbt-labs/arrow-adbc
that referenced
this pull request
Jun 10, 2025
…pache#2653) The driver does not prevent you from closing a statement when there is still an open result set. Then closing the result set would crash. Avoid this by having the result set keep a weak pointer to the actual state. Fixes apache#2629.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver does not prevent you from closing a statement when there is still an open result set. Then closing the result set would crash. Avoid this by having the result set keep a weak pointer to the actual state.
Fixes #2629.