fix(ci): fix MacOS builds for C# #2606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix MacOS builds by moving to newer SourceLink
CurtHagenlocher
requested review from
kou,
lidavidm and
zeroshade
as code owners
Contributor
Author
|
From what I can tell, the sourcelink command line tool is deprecated and MacOS is refusing to download it based on it having a very old signature. According to this link, only versions of .NET before 8.0 need to explicitly reference the GitHub SourceLink package, so that's what I've done here. The main Arrow repo references it unconditionally, which is probably okay too. |
CurtHagenlocher
changed the title
lidavidm
approved these changes
Mar 11, 2025
Member
|
Should we link to #2568? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MacOS builds for C# by moving to newer SourceLink
Closes #2568.