Skip to content

Conversation

@davidhcoe
Copy link
Contributor

Add support for net472 to the BigQuery driver.

@github-actions github-actions bot added this to the ADBC Libraries 17 milestone Feb 15, 2025
@CurtHagenlocher
Copy link
Contributor

CurtHagenlocher commented Feb 15, 2025

Why doesn't the netstandard2.0 build work for net472? Is this because of the ValueTuple problem?

@davidhcoe
Copy link
Contributor Author

I dont know if it's that, but I am getting:

Project '[x].csproj' targets 'net8.0-windows'. It cannot be referenced by a project that targets '.NETFramework,Version=v4.7.2'.

But [x].csproj has <NetFxVersionMoniker>net472</NetFxVersionMoniker>.

@CurtHagenlocher
Copy link
Contributor

CurtHagenlocher commented Feb 15, 2025

This is interesting because the core Arrow assembly targets netstandard2.0 and not net472 and I guess that one doesn't cause a problem in this scenario?

Let's be consistent between projects and if we're adding net472 here then I think we should also add netstandard2.0 to Apache.Arrow.Adbc.Drivers.Apache.csproj. This will require a minor edit to lines 91-93 of SqlTypeNameParser.cs to call the HashSet<> ctor instead of using ToHashSet().

@CurtHagenlocher CurtHagenlocher merged commit 8f2b31a into apache:main Feb 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants