fix(csharp/src/Apache.Arrow.Adbc/C): export statement_execute_schema correctly #2409
Conversation
…ectly from c# exporter try01
albertli-msft
requested review from
CurtHagenlocher and
lidavidm
as code owners
albertli-msft
changed the title
albertli-msft
changed the title
lidavidm
changed the title
|
This is actually not correct. ExecuteSchema was added in 1.1, for which the exporter doesn't yet have support. |
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
This change is not correct. StatementExecuteSchema was not added until ADBC 1.1, for which the native exporter does not yet have support.
| nativeDriver->StatementRelease = StatementReleasePtr; | ||
| nativeDriver->StatementSetSqlQuery = StatementSetSqlQueryPtr; | ||
| nativeDriver->StatementSetSubstraitPlan = StatementSetSubstraitPlanPtr; | ||
| nativeDriver->StatementGetParameterSchema = StatementGetParameterSchemaPtr; |
There was a problem hiding this comment.
These fields are deliberately initialized in the order that they are declared in adbc.h to make it easy to compare the two. If you look at that definition, you'll see that StatementGetParameterSchema does indeed come immediately after StatementExecutePartitions and that StatementExecuteSchema doesn't come until the 1.1 section.
There was a problem hiding this comment.
Ahhh, I see, thank Curt for the clarification.
|
Ah, sorry, let me put up a revert... |
|
I should also remove myself from the codeowners now that you're around |
…_schema correctly (apache#2409)" This reverts commit 1d268e9.
|
No worries! Thanks for contributing! |
3 participants
Fix a minor typo,
I think we accidentally forgot to export the
statement_execute_schemahandler from the C# exporter. And mistook StatementGetParameterSchema for it, as they two looked so alike to each other...so, this should restore it, please kindly approve.