feat(csharp/src/Drivers/Apache): Add support for Impala ADBC Driver with Refactoring and Unit Tests #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kushaman
commented
Dec 11, 2024
kushaman
commented
- Added support for the Impala ADBC driver with both standard and HTTP transport protocols.
- Refactored the existing Spark and Impala code to move common functionalities into a shared HiveServer2.
- Updated Spark unit tests to align with shared functionalities for Impala and Spark.
- Added new unit tests for Impala ADBC driver support.
Contributor
|
The Spark and Impala tests are passing for me. Can we get this closed out by early next week @CurtHagenlocher ? |
CurtHagenlocher
requested changes
Jan 14, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks for this work! I've left a bunch of feedback.
CurtHagenlocher
approved these changes
Jan 29, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks @kushaman !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.