feat(csharp/src/Client): parse custom properties from connection string #2352
Conversation
birschick-bq
left a comment
birschick-bq
left a comment
There was a problem hiding this comment.
Looks good to me.
I had a question about the use of ConnectionTimeout in this scenario and a suggestion on maybe a different choice for the parsing exception.
| CommandTimeoutValue = ConnectionStringParser.ParseTimeoutValue(paramValue); | ||
| break; | ||
| case ConnectionStringKeywords.ConnectionTimeout: | ||
| this.connectionTimeoutValue = ConnectionStringParser.ParseTimeoutValue(paramValue); |
There was a problem hiding this comment.
Since this has no effect on the underlying ADBC driver, is this to help synchronize the value with the driver?
There was a problem hiding this comment.
You are right in that it doesn't do much. The initial driver value would get set when the properties are passed in for the driver. However, ConnectionTimeout is only a get call, and it would differ from the actual value that was passed in. That said, maybe this could be better if you have an idea.
There was a problem hiding this comment.
I made a slight tweak to it so that it will set the property on the driver if it is passed in and it will also have a matching get value in that case.
|
@davidhcoe - Everything else looks good to me. |
Co-authored-by: Bruce Irschick <[email protected]>
3 participants
Follow up to #2312 to add parsing of the timeout values and other custom properties like StructBehavior and DecimalBehavior from the connection string.