fix(ci): ensure wheels are built with older manylinux #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
force-pushed
the
gh-2350
branch
2 times, most recently
from
4ee5866 to
6b29c7d
Compare
zeroshade
approved these changes
Dec 4, 2024
Contributor
|
Looks good. Slightly tangential question - is there a reason we choose to do this all via docker instead of using the cibuildwheel service? |
Member
Author
|
I chose docker mostly because then I can also run the exact same setup locally |
Member
|
nanoarrow is admittedly much less complex, but we use cibuildwheel using mostly defaults, with https://github.com/apache/arrow-nanoarrow/blob/e54b7df525fa1d310a96687bd99902823402b26c/ci/scripts/test-python-wheels.sh#L44-L51 to test locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2350.