Skip to content

feat(csharp/src/Drivers): introduce Interop.FlightSql driver #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CurtHagenlocher merged 42 commits into from
Dec 4, 2024
Merged

feat(csharp/src/Drivers): introduce Interop.FlightSql driver #2214

CurtHagenlocher merged 42 commits into from
Dec 4, 2024

Conversation

@davidhcoe
Copy link
Contributor

@davidhcoe davidhcoe commented Oct 2, 2024 •
edited
Loading

David Coe and others added 21 commits February 5, 2024 17:51
introduce FlightSql interop
4655e76
more updates
91d44f6
Merge ssh://github.com/davidhcoe/arrow-adbc into dev/go-flight-sql-in…
f3d9c3c 
…terop
ExecuteResults working
5c35df5
Merge ssh://github.com/davidhcoe/arrow-adbc into dev/go-flight-sql-in…
a69c345 
…terop
latest flight
57f8ef2
@vleslief-ms
Merging from main repo
257b70a
@vleslief-ms
test(csharp/test/Drivers/Interop/FlightSql): Getting tests working be…
c491911 
…st as possible on Dremio
update to latest; clean up nulls
9eaa016
getting on par with Snowflake interop
4027d2a
Merge ssh://github.com/davidhcoe/arrow-adbc into dev/go-flight-sql-in…
54730c7 
…terop
add support for multiple flight environments; type tests
35d2bfe
Merge ssh://github.com/davidhcoe/arrow-adbc into dev/go-flight-sql-in…
2fca8e4 
…terop
add support for IntervalType
4f633b4
working on multi environments
8f04808
Merge ssh://github.com/davidhcoe/arrow-adbc into dev/go-flight-sql-in…
1474e1b 
…terop
support multiple test environments
a2cdadf
Merge ssh://github.com/davidhcoe/arrow-adbc into dev/go-flight-sql-in…
1488ff0 
…terop
support multiple environments in tests
68ef07b
Merge ssh://github.com/davidhcoe/arrow-adbc into dev/go-flight-sql-in…
f850e56 
…terop
clean up after merge; multi-environment support for sample data
1891827
@github-actions github-actions bot added this to the ADBC Libraries 15 milestone Oct 2, 2024
@davidhcoe davidhcoe marked this pull request as draft October 3, 2024 13:58
@davidhcoe davidhcoe marked this pull request as ready for review October 3, 2024 17:47
zeroshade
zeroshade reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to make the process of creating something to load the driver and wrap it more generic so that potential future drivers don't require as much boiler plate as this appears to?

Otherwise, this looks pretty fine to me but I'm not very experienced with C#

@zeroshade
Copy link
Member

zeroshade commented Oct 15, 2024

Like a base class that https://github.com/apache/arrow-adbc/blob/7fc08cce7404b000c400e00f208ded6dc80f6bb8/csharp/src/Drivers/Interop/FlightSql/FlightSqlDriverLoader.cs could implement?

Exactly

@davidhcoe davidhcoe marked this pull request as draft November 21, 2024 03:02
@davidhcoe
Copy link
Contributor Author

davidhcoe commented Nov 21, 2024

Is there any way to make the process of creating something to load the driver and wrap it more generic so that potential future drivers don't require as much boiler plate as this appears to?

Otherwise, this looks pretty fine to me but I'm not very experienced with C#

I added this in a recent push.

@davidhcoe davidhcoe marked this pull request as ready for review December 2, 2024 17:23
@davidhcoe
Copy link
Contributor Author

davidhcoe commented Dec 3, 2024

I also verified this against Denodo https://community.denodo.com/docs/html/browse/9.1/en/vdp/developer/access_through_flight_sql/access_through_flight_sql#current-restrictions

@CurtHagenlocher
Copy link
Contributor

CurtHagenlocher commented Dec 4, 2024

@davidhcoe Can you please resolve the build conflicts?

@davidhcoe
Copy link
Contributor Author

davidhcoe commented Dec 4, 2024

@davidhcoe Can you please resolve the build conflicts?

ready now

@CurtHagenlocher CurtHagenlocher merged commit 08ac053 into apache:main Dec 4, 2024
6 checks passed
@davidhcoe davidhcoe deleted the dev/go-flight-sql-interop branch December 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeroshade zeroshade zeroshade left review comments

@lidavidm lidavidm lidavidm approved these changes

@CurtHagenlocher CurtHagenlocher CurtHagenlocher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 16

Development

Successfully merging this pull request may close these issues.

5 participants

@davidhcoe @lidavidm @zeroshade @CurtHagenlocher @vleslief-ms