Skip to content

Conversation

@mbrobbel
Copy link
Member

@mbrobbel mbrobbel commented Oct 1, 2024

As discussed in #1725 (comment), we can now use the arrow-* subcrates. This also bumps these arrow crates to the latest release. This is a breaking change for the adbc_core crate.

@mbrobbel mbrobbel requested a review from wjones127 as a code owner October 1, 2024 20:50
@github-actions github-actions bot added this to the ADBC Libraries 15 milestone Oct 1, 2024
@lidavidm
Copy link
Member

lidavidm commented Oct 6, 2024

CI isn't actually running (https://github.com/apache/arrow-adbc/actions/runs/11133252620)

The workflow is not valid. .github/workflows/rust.yml (Line: 45, Col: 3): Error calling workflow 'apache/arrow-adbc/.github/workflows/native-unix.yml@6bdf5d5'. The nested job 'go-no-cgo' is requesting 'id-token: write', but is only allowed 'id-token: none'. .github/workflows/rust.yml (Line: 45, Col: 3): Error calling workflow 'apache/arrow-adbc/.github/workflows/native-unix.yml@6bdf5d5'. The nested job 'go-conda' is requesting 'id-token: write', but is only allowed 'id-token: none'.

@mbrobbel mbrobbel requested a review from zeroshade as a code owner October 7, 2024 07:25
@lidavidm
Copy link
Member

lidavidm commented Oct 7, 2024

Thanks, now it seems Clippy is unhappy...

@mbrobbel mbrobbel changed the title chore(rust)!: use arrow-* subcrates and bump to 53 chore(rust)!: use arrow-* subcrates and bump to 53.1.0 Oct 7, 2024
@mbrobbel
Copy link
Member Author

mbrobbel commented Oct 7, 2024

Are the failing tests known to be flaky?

FAILED python/adbc_driver_flightsql/tests/test_errors.py::test_query_error_bind - AssertionError: Regex pattern did not match.
 Regex: 'UNKNOWN:\\ \\[FlightSQL\\]\\ expected\\ error\\ \\(DoPut\\)'
 Input: 'UNKNOWN: [FlightSQL] EOF (Unknown; ExecuteQuery)'
FAILED python/adbc_driver_flightsql/tests/test_errors.py::test_stateless_prepared_statement - adbc_driver_manager.OperationalError: UNKNOWN: [FlightSQL] EOF (Unknown; ExecuteQuery)

@lidavidm
Copy link
Member

lidavidm commented Oct 7, 2024

Yes.

(TBH: why are we running those tests for Rust in the first place?)

@mbrobbel
Copy link
Member Author

mbrobbel commented Oct 7, 2024

Yes.

(TBH: why are we running those tests for Rust in the first place?)

It seems the native-unix workflow runs to produce some artifacts that are required to run the Rust unit tests. It would probably be better to just build the required lib(s) as part of the CI job (or even as part of the Rust build script). What do you think?

@lidavidm
Copy link
Member

lidavidm commented Oct 7, 2024

We could perhaps split the pipeline into a build and a test phase? (I believe we already sort of do this split within the pipeline itself)

@lidavidm
Copy link
Member

lidavidm commented Oct 8, 2024

IMO, let's merge this for now though.

@lidavidm lidavidm merged commit c74f3d3 into apache:main Oct 8, 2024
@mbrobbel mbrobbel deleted the rust/arrow-crates branch October 8, 2024 09:54
lidavidm pushed a commit that referenced this pull request Oct 8, 2024
This step fails on `main` because the `build` directory does not exist.
This was added in #2208, but never ran because the `native-unix` job was
failing because of flaky tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants