ARROW-12176: [C++] Fix some typos of cpp examples#9870
Closed
Clcanny wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-12176: [C++] Fix some typos of cpp examples#9870Clcanny wants to merge 1 commit intoapache:masterfrom
Clcanny wants to merge 1 commit intoapache:masterfrom
Conversation
Clcanny
force-pushed
the
fix-reader-writer-example-typo
branch
from
8c01127 to
3387391
Compare
cyb70289
changed the title
cyb70289
requested changes
Apr 2, 2021
Contributor
There was a problem hiding this comment.
2. reader_writer.h and reader-writer.cc are not compatible, when you use vim to edit them, it's confuse why `:A` doesn't work.
@pitrou, Shall we use underscore for all source file names? Looks files in cpp/examples use both hyphen and underscore.
https://github.com/apache/arrow/tree/master/cpp/examples
Clcanny
force-pushed
the
fix-reader-writer-example-typo
branch
from
3387391 to
926e397
Compare
…pi/reader-writer.cc
Clcanny
force-pushed
the
fix-reader-writer-example-typo
branch
from
926e397 to
7c0b762
Compare
Member
Yes, we should. We probably forgot to convert these files. |
cyb70289
approved these changes
Apr 6, 2021
Contributor
Created jira https://issues.apache.org/jira/browse/ARROW-12217 |
pachadotdev
pushed a commit
to pachadotdev/arrow
that referenced
this pull request
Apr 6, 2021
There are two typos: 1. In comment: `*memory consumption.` -> `* memory consumption`. 2. reader_writer.h and reader-writer.cc are not compatible, when you use vim to edit them, it's confuse why `:A` doesn't work. Closes apache#9870 from Clcanny/fix-reader-writer-example-typo Authored-by: Clcanny <[email protected]> Signed-off-by: Yibo Cai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two typos:
*memory consumption.->* memory consumption.:Adoesn't work.