ARROW-12160: [Rust] Add into_inner() to StreamWriter#9858
Closed
ericwburden wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-12160: [Rust] Add into_inner() to StreamWriter#9858ericwburden wants to merge 2 commits intoapache:masterfrom
into_inner() to StreamWriter#9858ericwburden wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you @ericwburden |
nevi-me
approved these changes
Mar 31, 2021
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
LGTM, thanks @ericwburden
Contributor
|
@alamb we can merge after the clippy and Debian 10 CI tasks complete |
Contributor
|
Thanks again @ericwburden -- this is really helpful. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
into_inner()method toipc::writer::StreamWriter, allowing users to recover the underlying writer, consuming the StreamWriter. Essentially exposesinto_inner()from the BufWriter contained in the StreamWriter. The StreamWriter will 'finish' itself if not already finished when returning the writer.Also added
ArrowError::From<std::io::IntoInnerError>conversion to allow for ergonomic return of the potentialIntoInnerErrorreturned byBufWriter.into_inner().