ARROW-12134: [C++] Add match_substring_regex kernel#9838
ARROW-12134: [C++] Add match_substring_regex kernel#9838lidavidm wants to merge 7 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
There's no conceptual reason for matchers to be templated on offset type. The iteration loop on string values could be moved out of the matcher and into the calling MatchSubstring class. Then all a matcher does is take a string_view or similar and return the index where the pattern was found (or presumably -1 if not found).
There was a problem hiding this comment.
Got it, I refactored that part. The Knuth-Morris-Pratt implementation also had to be refactored as it was templated on offset_type, though it seems that was unnecessary.
docs/source/cpp/compute.rst
Outdated
There was a problem hiding this comment.
You missed the renumbering of notes here (and below).
|
It looks like there's a failure on Windows in debug mode (see CI): |
|
It's reproducible on Linux by temporarily using .at() for array access. I incorrectly turned |
|
This should be ready again (minus RTools 3.5/JNI which are known to be failing/flaky). |
For consistency with match_substring, this is the equivalent of Python's re.search(), not re.match(). Closes apache#9838 from lidavidm/arrow-12134 Authored-by: David Li <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
3 participants
For consistency with match_substring, this is the equivalent of Python's re.search(), not re.match().