ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions #9816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
anthonylouisbsb
force-pushed
the
feature/fix-castvarchar-to-match-java-impl
branch
from
9a856be to
433442c
Compare
projjal
reviewed
Mar 30, 2021
anthonylouisbsb
force-pushed
the
feature/fix-castvarchar-to-match-java-impl
branch
6 times, most recently
from
818027e to
ede5890
Compare
anthonylouisbsb
force-pushed
the
feature/fix-castvarchar-to-match-java-impl
branch
2 times, most recently
from
58f6d74 to
6e9ec45
Compare
projjal
reviewed
Apr 7, 2021
anthonylouisbsb
force-pushed
the
feature/fix-castvarchar-to-match-java-impl
branch
from
7e8ae59 to
24c2fbf
Compare
projjal
approved these changes
Apr 7, 2021
anthonylouisbsb
force-pushed
the
feature/fix-castvarchar-to-match-java-impl
branch
7 times, most recently
from
0331750 to
e167e07
Compare
projjal
approved these changes
Apr 12, 2021
anthonylouisbsb
force-pushed
the
feature/fix-castvarchar-to-match-java-impl
branch
3 times, most recently
from
fcd7bb7 to
e915d26
Compare
anthonylouisbsb
force-pushed
the
feature/fix-castvarchar-to-match-java-impl
branch
from
e915d26 to
7df55a5
Compare
projjal
added a commit
to projjal/arrow
that referenced
this pull request
Apr 21, 2021
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache#8158 PR to change the function output to match the Java language patterns. Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <[email protected]> Co-authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
kou
pushed a commit
that referenced
this pull request
Jun 9, 2023
…, remove patches (#36002) [double-conversion v3.3.0](https://github.com/google/double-conversion/releases/tag/v3.3.0) adds a [new feature](google/double-conversion#195) that allows us to remove the special code that was added to our vendored copy of double-conversion in #9816. This PR: * Updates vendored double-conversion to v3.3.0 * Activates the new flags `EMIT_TRAILING_DECIMAL_POINT_IN_EXPONENTIAL` and `EMIT_TRAILING_ZERO_AFTER_POINT_IN_EXPONENTIAL` * Removes the patches in `cpp/src/arrow/vendored/double-conversion/patches` ----- * Closes: #35669 Authored-by: Ian Cook <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache#8158 PR to change the function output to match the Java language patterns. Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <[email protected]> Co-authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the castVARCHAR for numeric values inside the Gandiva.
It replaces the logic of the #8158 PR to change the function output to match the Java language patterns.