ARROW-11259: [Python][Dataset] Allow creating nested field ref#9799
ARROW-11259: [Python][Dataset] Allow creating nested field ref#9799pitrou wants to merge 1 commit intoapache:masterfrom
Conversation
We can't yet filter on a nested field ref, so this merely adds syntactical support.
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
This patch seems well put together of itself, but does it add value to support construction of nested field references if we can't filter on them yet? It seems first we should refactor the parts of scan which depend on non nested field refs (ScanOptions::MaterializedFields, SetProjection) before exposing anything in python
Probably not, but it also should be relatively orthogonal to future refactors? |
|
We do plan to support nested field references in filters? If so I am fine with already merging this, but no strong opinion. |
|
Should I close this PR? @bkietz |
|
Now there is actual support for nested field refs (#11466), this PR can be revived? |
|
@jorisvandenbossche Do you want to take it up? |
|
Yes, will do |
This PR tries to redo the work from #9799. It will unblock: - https://issues.apache.org/jira/browse/ARROW-13798 - https://issues.apache.org/jira/browse/ARROW-14596 cc @jorisvandenbossche @pitrou Closes #12863 from AlenkaF/ARROW-11259 Lead-authored-by: Alenka Frim <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
3 participants
We can't yet filter on a nested field ref, so this merely adds syntactical support.