ARROW-1347: [JAVA] return consistent child field name for List vectors#959
Closed
StevenMPhillips wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-1347: [JAVA] return consistent child field name for List vectors#959StevenMPhillips wants to merge 1 commit intoapache:masterfrom
StevenMPhillips wants to merge 1 commit intoapache:masterfrom
Conversation
BryanCutler
approved these changes
Aug 16, 2017
Member
BryanCutler
left a comment
BryanCutler
left a comment
There was a problem hiding this comment.
Just one small question, otherwise LGTM
|
|
||
| @Override | ||
| public Field getField() { | ||
| if (getDataVector() == ZeroVector.INSTANCE) { |
Member
There was a problem hiding this comment.
I know that the vector is initialized to ZeroVector.INSTANCE right now, but would this be a little better as if (getDataVector() instanceof ZeroVector)?
Contributor
There was a problem hiding this comment.
What was the previous field name?
Member
There was a problem hiding this comment.
I believe it was the ZeroVector.name which is "[DEFAULT]"
Member
|
Can this be merged? |
Contributor
|
LGTM +1. |
Member
|
Wouldn't it be better to use |
Contributor
Author
|
Thanks, @BryanCutler, if you want to go ahead and post your suggested change, I can merge it. |
Member
|
@StevenMPhillips can you close this stale PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.