ARROW-11724: [C++] Resolve namespace collisions with protobuf 3.15#9542
Closed
xhochy wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-11724: [C++] Resolve namespace collisions with protobuf 3.15#9542xhochy wants to merge 1 commit intoapache:masterfrom
xhochy wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@github-actions autotune |
pitrou
reviewed
Feb 22, 2021
cpp/src/arrow/flight/client.cc
Outdated
Member
There was a problem hiding this comment.
What if you put the "namespace pb" alias inside the arrow namespace below?
There is no reason to believe that top-level afpb won't conflict with another library.
Member
Author
There was a problem hiding this comment.
Yes, that worked. CI is green again.
Member
Author
There was a problem hiding this comment.
Yes, that worked. CI is green again.
2742204 to
5ef559b
Compare
pitrou
approved these changes
Feb 23, 2021
Member
|
The Homebrew formula patch that this PR obviates the need for is removed in Homebrew/homebrew-core#76060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames our alias to
afpbto not clash withprotobuf's definition.Original error: