ARROW-11497: [Python] Provide parquet enable compliant nested type flag for python binding#9489
ARROW-11497: [Python] Provide parquet enable compliant nested type flag for python binding#9489trucnguyenlam wants to merge 6 commits intoapache:masterfrom trucnguyenlam:provide-parquet-enable-compliant-nested-type-flag
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
trucnguyenlam
changed the title
|
@trucnguyenlam thank you for the PR it looks like the CI failure is legitimate here. Otherwise looks good to me CC @jorisvandenbossche for python/cython style check |
|
@emkornfield thanks for your comment, I've also resolved python/cython style check, hopefully this should be good enough to be merged. |
jorgecarleitao
force-pushed
the
master
branch
2 times, most recently
from
d4608a9 to
356c300
Compare
|
@emkornfield @jorisvandenbossche Is it ok to be merged now? thanks |
|
@trucnguyenlam it seems you have some unrelated changes included (some git problem I suppose). Can you rebase this on master? |
|
@jorisvandenbossche done rebase and expanded doc, please have a look if it is ok to merge |
|
@jorisvandenbossche please have a look if it is ok to merge? I resolved all issues as far as I know. |
|
@jorisvandenbossche could you please have a look at the PR? cheers |
|
@jorisvandenbossche @emkornfield this is open for quite some time, please have a look if this is eligible to be merged, thanks |
|
+1, going to merge, we can address any items as a followup. @trucnguyenlam apologies for the delay. |
trucnguyenlam
deleted the
provide-parquet-enable-compliant-nested-type-flag
branch
4 participants
Hi,
I am making a PR following the discussion in ARROW-11497
This is my first PR to this project, please let me know if I'm missing something, I will try to address all problem as much as I can.
Cheers,
Truc