ARROW-11603: [Rust] Fix Clippy Lints for Rust 1.50#9476
Closed
alamb wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-11603: [Rust] Fix Clippy Lints for Rust 1.50#9476alamb wants to merge 1 commit intoapache:masterfrom
alamb wants to merge 1 commit intoapache:masterfrom
Conversation
jorgecarleitao
approved these changes
Feb 11, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot, @alamb
Contributor
Author
|
I plan to merge this in as soon as it goes green, unless I hear otherwise. I feel the CI breakage is pretty bad for contributors. I'll try and take a pass through the PRs too to note that there is a CI breakage. |
Contributor
Author
|
Well, Clippy passed :) but the integration test is still running. I am about to be away from my keyboard for a few hours -- I'll merge this when I get back if someone doesn't beat me to it, |
Codecov Report
@@ Coverage Diff @@
## master #9476 +/- ##
==========================================
- Coverage 82.32% 82.31% -0.02%
==========================================
Files 233 233
Lines 54446 54414 -32
==========================================
- Hits 44823 44791 -32
Misses 9623 9623
Continue to review full report at Codecov.
|
jorgecarleitao
changed the title
sgnkc
pushed a commit
to sgnkc/arrow
that referenced
this pull request
Feb 17, 2021
# Rationale: CI uses "stable" rust. 1.50 stable was released today: https://blog.rust-lang.org/2021/02/11/Rust-1.50.0.html The new clippy is pickier resulting in many clippy warnings such as https://github.com/apache/arrow/pull/9469/checks?check_run_id=1881854256 We need to get CI back green # Changes Based on based on apache#9475 from @nevi-me, this PR aims to get the CI green as soon as possible. Ideally, we would fix the actual lint problems, However, when I tried to do so the lints propagated into a significant change -- as clippy says to remove the `Result` but then there are a bunch of call sites that then also need t be changed I want to get CI back clean as soon as possible so I just hammered through and cleaned up as best I could as well as sprinkling in various `#[allow(clippy::unnecessary_wraps)]` as necessary to get a clean run. My rationale is that the code is no worse than it was before. Though it could be better! Closes apache#9476 from alamb/ARROW-11602-lints Authored-by: Neville Dipale <[email protected]> Signed-off-by: Jorge C. Leitao <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
CI uses "stable" rust. 1.50 stable was released today: https://blog.rust-lang.org/2021/02/11/Rust-1.50.0.html
The new clippy is pickier resulting in many clippy warnings such as https://github.com/apache/arrow/pull/9469/checks?check_run_id=1881854256
We need to get CI back green
Changes
Based on based on #9475 from @nevi-me, this PR aims to get the CI green as soon as possible.
Ideally, we would fix the actual lint problems, However, when I tried to do so the lints propagated into a significant change -- as clippy says to remove the
Resultbut then there are a bunch of call sites that then also need t be changedI want to get CI back clean as soon as possible so I just hammered through and cleaned up as best I could as well as sprinkling in various
#[allow(clippy::unnecessary_wraps)]as necessary to get a clean run.My rationale is that the code is no worse than it was before. Though it could be better!