ARROW-11442: [Rust] Expose datetime conversion logic independently#9378
Closed
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:conversions
Closed
ARROW-11442: [Rust] Expose datetime conversion logic independently#9378jorgecarleitao wants to merge 1 commit intoapache:masterfrom jorgecarleitao:conversions
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:conversions
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9378 +/- ##
==========================================
+ Coverage 81.94% 81.96% +0.01%
==========================================
Files 231 231
Lines 53374 53372 -2
==========================================
+ Hits 43739 43748 +9
+ Misses 9635 9624 -11
Continue to review full report at Codecov.
|
Contributor
|
This looks good 👍! This would also be helpful for removing some indirection in the temporal kernels. Maybe the module name could be called |
alamb
approved these changes
Feb 1, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @jorgecarleitao
Contributor
|
I think this is small enough / not backwards breaking to merge. So doing so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small refactor that exposes the functions used to convert dates and times into
NaiveDate,NaiveTimeandNaiveDateTime. They are currently hidden beind thePrimitiveArray<ArrowTemporalType>::value_as_time, which makes them difficult to use when the transformation is to be applied in SIMD, or when we want to reproduce the operation for a single scalar value (not in an arrow array).