ARROW-1246: [Format] Draft Flatbuffer metadata description for Map#876
ARROW-1246: [Format] Draft Flatbuffer metadata description for Map#876wesm wants to merge 3 commits intoapache:masterfrom
Conversation
Change-Id: I335c5fc820dda617c46c36b30935ed554d892bca
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, sounds reasonable from my side.
|
Sounds good to me. I was thinking about how to store Map data from Spark, which is just (key, value) pairs, in Arrow and assumed I'd have to make the types myself into something like |
jacques-n
left a comment
jacques-n
left a comment
There was a problem hiding this comment.
Generally looks good. One small question
format/Schema.fbs
Outdated
| /// - child[0] key: K | ||
| /// - child[1] value: V | ||
| /// | ||
| /// As a matter of convention, neither values of the "entry" nor "key" fields |
There was a problem hiding this comment.
Not sure your meaning here. Seems like this should be a formal specification, not a convention.
There was a problem hiding this comment.
Good point; I think this is just a language issue. What I mean is that "neither entry nor key fields may have nulls"
There was a problem hiding this comment.
I'm +1 after you clarify. Thanks!
Change-Id: I813e52b97f1d773d975ac8df66c566e770edab9c
|
Thanks for the review, all. @jacques-n is there specialized code for handling maps in this form in the Arrow Java library, or Dremio? |
|
No, we should open a jira to support |
4 participants
No description provided.